Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38067 - Replace deprecated wget "-Y off" #10398

Merged

Conversation

jloeser
Copy link

@jloeser jloeser commented Dec 5, 2024

As the parameter is not part of the manpage anymore [1] (but still supported for backward compatibility reasons [2]) this might confuse people.

Correct parameter would be wget --no-proxy.

[1]:http://git.savannah.gnu.org/cgit/wget.git/commit/?id=0734d8dd3744825c4db56ef0f50bcff111efa18e [2]:http://git.savannah.gnu.org/cgit/wget.git/commit/?id=e3acbd2aaf2c1a6556b20243781f4e4b83dbd2a2

As the parameter is not part of the manpage anymore [1] (but still
supported for backward compatibility reasons [2]) this might confuse
people.

Correct parameter would be `wget --no-proxy`.

[1]:http://git.savannah.gnu.org/cgit/wget.git/commit/?id=0734d8dd3744825c4db56ef0f50bcff111efa18e
[2]:http://git.savannah.gnu.org/cgit/wget.git/commit/?id=e3acbd2aaf2c1a6556b20243781f4e4b83dbd2a2
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the self-documenting long options in scripts.

@ekohl ekohl merged commit 87652e5 into theforeman:develop Dec 6, 2024
51 checks passed
@maximiliankolb maximiliankolb deleted the refactor/wget-no-proxy-replacement branch December 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants